Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't clear all upstream tasks when DAG Serialization is enabled #8720

Closed
kaxil opened this issue May 5, 2020 · 2 comments · Fixed by #8775
Closed

Can't clear all upstream tasks when DAG Serialization is enabled #8720

kaxil opened this issue May 5, 2020 · 2 comments · Fixed by #8775
Assignees
@ashb
Labels
kind:bug This is a clearly a bug

Comments

@kaxil
Copy link
Member

kaxil commented May 5, 2020 •
edited
Loading

Apache Airflow version: 1.10.10

To Reproduce
Steps to reproduce the behavior with Astronomer Image:

  1. Enable DAG Serialization (Put AIRFLOW__CORE__STORE_SERIALIZED_DAGS=True
    Once the Webserver boots up, run any DAG
  2. Once the DAG completes execution, click on the task that has few upstream tasks in Graph View
  3. One the Task Instance Modal, select Upstream -> click on Clear. You will see a list of tasks but that would not have all the upstream tasks.

Screenshots
Apr-22-2020 15-56-14
@kaxil kaxil added the kind:bug This is a clearly a bug label May 5, 2020
@kaxil kaxil self-assigned this May 5, 2020
@kaxil kaxil mentioned this issue May 5, 2020
Closed
6 tasks
@kaxil kaxil added this to the Airflow 1.10.11 milestone May 5, 2020
@ashb
Copy link
Member

ashb commented May 7, 2020

I think I have a fix for this

@kaxil kaxil assigned ashb and unassigned kaxil May 7, 2020
@ashb ashb mentioned this issue May 7, 2020
Merged
6 tasks
ashb added a commit to astronomer/airflow that referenced this issue May 10, 2020
@ashb
Correctly restore upstream_task_ids when deserializing Operators
0618800 
This test exposed a bug in one of the example dags, that wasn't caught
by apache#6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes apache#8720
ashb added a commit that referenced this issue May 10, 2020
@ashb
Correctly restore upstream_task_ids when deserializing Operators (#8775)
280f1f0 
This test exposed a bug in one of the example dags, that wasn't caught
by #6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes #8720
ashb added a commit to astronomer/airflow that referenced this issue May 18, 2020
@ashb
Correctly restore upstream_task_ids when deserializing Operators (apa…
bf04e3e 
…che#8775)

This test exposed a bug in one of the example dags, that wasn't caught
by apache#6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes apache#8720

(cherry picked from commit 280f1f0)
@kaxil kaxil removed this from the Airflow 1.10.11 milestone Jun 26, 2020
@kaxil
Copy link
Member Author

kaxil commented Jun 26, 2020

Fixed in 1.10.11

kaxil pushed a commit that referenced this issue Jun 26, 2020
@ashb @kaxil
Correctly restore upstream_task_ids when deserializing Operators (#8775)
45bf7f4 
This test exposed a bug in one of the example dags, that wasn't caught
by #6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes #8720

(cherry picked from commit 280f1f0)
potiuk pushed a commit that referenced this issue Jun 29, 2020
@ashb @potiuk
Correctly restore upstream_task_ids when deserializing Operators (#8775)
04f7911 
This test exposed a bug in one of the example dags, that wasn't caught
by #6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes #8720

(cherry picked from commit 280f1f0)
kaxil pushed a commit that referenced this issue Jul 1, 2020
@ashb @kaxil
Correctly restore upstream_task_ids when deserializing Operators (#8775)
36ce7a2 
This test exposed a bug in one of the example dags, that wasn't caught
by #6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes #8720

(cherry picked from commit 280f1f0)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this issue Mar 5, 2021
@ashb
Correctly restore upstream_task_ids when deserializing Operators (apa…
3265b89 
…che#8775)

This test exposed a bug in one of the example dags, that wasn't caught
by apache#6549. That will be a fixed in a separate issue, but it caused the
round-trip tests to fail here

Fixes apache#8720

(cherry picked from commit 280f1f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashb ashb

Labels
kind:bug This is a clearly a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly restore upstream_task_ids when deserializing Operators astronomer/airflow
2 participants
@ashb @kaxil