-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UniqueConnIdRule rule and unittest #11222
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
@edeNFed please get tests to pass and then I'll merge |
@dimberman do you have an idea how to do this? I can see that tests were skipped in every PR opened to v1-10-test... |
@edeNFed Can you please rebase to latest v1-10-test ? It should work now. |
d4d239f
to
56d6f76
Compare
56d6f76
to
3ff87bc
Compare
@dimberman @turbaszek all tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the suggested change it looks good to me:
Connection.conn_id is not unique
--------------------------------
The `id` column in the `connection` table must be unique. Previously, this rule was enforced by application logic, but was not enforced by the database schema.
If you made any modifications to the table directly, make sure you don't have duplicate values in conn_id column.
Problems:
1. Connection.conn_id=aaa is not unique.
Co-authored-by: Tomek Urbaszek <turbaszek@gmail.com>
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow, You can checks the status of those images in The workflow run |
Awesome work, congrats on your first merged pull request! |
(cherry picked from commit 03f1878)
(cherry picked from commit 03f1878)
Adds UniqueConnIdRule rule to upgrade/rules as per:
https://github.com/apache/airflow/blob/master/UPDATING.md#unique-conn_id-in-connection-table
Closes: #11037
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.