-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LegacyUIDeprecated rule and unittests #11185
Add LegacyUIDeprecated rule and unittests #11185
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @turbaszek!
@turbaszek replaced one quote with three quotes in the test msg, should be fine now |
@turbaszek thanks for approving! just to check, should I close the PR? I noticed some of the tests are being skipped - from the logs it indicates that perhaps it is failing for Python 2.7 |
bd4214b
to
195f00d
Compare
Please rebase your PR, we added few changes that should fix the CI issues. Please do rebase and try to avoid merge commits, more information: |
rebased PR with changes for fixing CI issues. added test if rbac is None |
@rafaelpierre if you would like I can help you with sorting out the commits 👍 |
@turbaszek much appreciated, thanks! I'm not that familiar with rebase :) one thing I'm struggling with is that I have already rebased, however it still shows that these files are conflicting: breeze-complete however, if you look into the first file in the my branch, it doesn't have any conflict (line 138 looks the same as from v1-10-test) |
56540e7
to
f3e9c68
Compare
rbac_conf = conf.get("webserver", "rbac") | ||
|
||
if rbac_conf == "false": | ||
msg = """rbac in airflow.cfg must be explicitly set empty as RBAC mechanism is enabled by default. """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we can use single quote string 👌
@rafaelpierre can you please take a look at the CI problems:
|
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow, You can checks the status of those images in The workflow run |
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow, You can checks the status of those images in The workflow run |
The Build Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
44f11a2
to
e367231
Compare
Adds LegacyUIDeprecated rule to
upgrade/rules
as per:https://github.com/apache/airflow/blob/master/UPDATING.md#drop-legacy-ui-in-favor-of-fab-rbac-ui
Closes: #11019
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.