-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python Helm testing framework #11693
Conversation
14fb732
to
436b391
Compare
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
436b391
to
f91816e
Compare
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
chart_tests/test_templates/git_sync_scheduler/git-sync-existing-claim.yaml
Outdated
Show resolved
Hide resolved
f76c0d6
to
eca0f34
Compare
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
eca0f34
to
c2960aa
Compare
:param name: | ||
:param values: | ||
:param show_only: | ||
:return: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either we should all the descriptions or remove these too
7ac2c24
to
a4f5624
Compare
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
@@ -277,7 +277,7 @@ repos: | |||
entry: "^\\s*from\\s+\\." | |||
pass_filenames: true | |||
files: \.py$ | |||
exclude: ^tests/ | |||
exclude: ^tests/|^chart/tests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is needed? We can solve pylint problems with a trick similar to mypy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is needed as if it's not excluded it will try to parse those files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this is expected behavior. Instead, we should use the correct imports.
-from .helm_template_generator import render_chart
+from tests.helm_template_generator import render_chart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Click File => Project structure
- On the left menu, select "Project settings => Modules
- Click + >> Add new module to a new project module
- Select Python
- Next
- Type Chart in "Module name"" field
- Finish
- Click Add Content Root and add
/chart
directory again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments remain. Besides LGTM
https://github.com/apache/airflow/pull/11693/files#r511162977
https://github.com/apache/airflow/pull/11693/files#r511163187
0babdba
to
c5e36d2
Compare
c5e36d2
to
106af04
Compare
🎉 Thanks! I will now migrate the rest of the files. |
* Helm Python Testing * helm change * add back args
* Helm Python Testing * helm change * add back args
* Helm Python Testing * helm change * add back args (cherry picked from commit 0d1ad66)
* Helm Python Testing * helm change * add back args (cherry picked from commit 0d1ad66)
* Helm Python Testing * helm change * add back args (cherry picked from commit 0d1ad66)
* Helm Python Testing * helm change * add back args (cherry picked from commit 0d1ad66)
* Helm Python Testing * helm change * add back args (cherry picked from commit 0d1ad66)
* Helm Python Testing * helm change * add back args Partial Commit Extracted From: https://github.com/apache/airflow
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.