Add Python Helm testing framework #11693

dimberman · 2020-10-20T16:05:56Z

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

github-actions · 2020-10-20T18:41:52Z

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

airflow/utils/helm_template_generator.py

tests/helm/__init__.py

tests/helm/test_git_sync_scheduler.py

scripts/ci/libraries/_local_mounts.sh

.dockerignore

github-actions · 2020-10-21T20:00:39Z

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

chart_tests/test_templates/git_sync_scheduler/git-sync-existing-claim.yaml

github-actions · 2020-10-21T21:17:33Z

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

kaxil · 2020-10-22T18:17:43Z

chart_tests/helm_template_generator.py

+    :param name:
+    :param values:
+    :param show_only:
+    :return:


Either we should all the descriptions or remove these too

chart_tests/basic_helm_chart_test.py

chart_tests/helm_template_generator.py

chart_tests/test_git_sync_scheduler.py

chart_tests/helm_template_generator.py

github-actions · 2020-10-22T22:19:16Z

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

scripts/in_container/entrypoint_ci.sh

mik-laj · 2020-10-25T23:31:02Z

.pre-commit-config.yaml

@@ -277,7 +277,7 @@ repos:
        entry: "^\\s*from\\s+\\."
        pass_filenames: true
        files: \.py$
-        exclude: ^tests/
+        exclude: ^tests/|^chart/tests/


It is needed? We can solve pylint problems with a trick similar to mypy.

I think this one is needed as if it's not excluded it will try to parse those files

In my opinion, this is expected behavior. Instead, we should use the correct imports.

-from .helm_template_generator import render_chart +from tests.helm_template_generator import render_chart

That works on the docker-based tests, but is shows an error on PyCharm which might make development difficult. Any idea how to fix that? I think pycharm usually assumes root.

Click File => Project structure

On the left menu, select "Project settings => Modules

Click + >> Add new module to a new project module

Select Python

Next

Type Chart in "Module name"" field

Finish

Click Add Content Root and add /chart directory again

TESTING.rst

github-actions · 2020-10-26T22:35:28Z

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

github-actions · 2020-10-26T22:35:40Z

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

mik-laj

Two comments remain. Besides LGTM
https://github.com/apache/airflow/pull/11693/files#r511162977
https://github.com/apache/airflow/pull/11693/files#r511163187

mik-laj · 2020-10-28T01:36:19Z

🎉 Thanks!

I will now migrate the rest of the files.
#11827

* Helm Python Testing * helm change * add back args

* Helm Python Testing * helm change * add back args (cherry picked from commit 0d1ad66)

* Helm Python Testing * helm change * add back args Partial Commit Extracted From: https://github.com/apache/airflow

boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Oct 20, 2020

dimberman mentioned this pull request Oct 20, 2020

Better unit tests for Helm Chart #11657

Closed

dimberman force-pushed the helm-testing-framework branch from 14fb732 to 436b391 Compare October 20, 2020 17:04

dimberman requested review from mik-laj, ashb and potiuk October 20, 2020 17:11

dimberman linked an issue Oct 20, 2020 that may be closed by this pull request

Better unit tests for Helm Chart #11657

Closed

dimberman marked this pull request as ready for review October 20, 2020 17:52

mik-laj reviewed Oct 20, 2020

View reviewed changes

airflow/utils/helm_template_generator.py Outdated Show resolved Hide resolved

mik-laj reviewed Oct 20, 2020

View reviewed changes

tests/helm/__init__.py Outdated Show resolved Hide resolved

mik-laj reviewed Oct 20, 2020

View reviewed changes

tests/helm/test_git_sync_scheduler.py Outdated Show resolved Hide resolved

mik-laj reviewed Oct 20, 2020

View reviewed changes

tests/helm/test_git_sync_scheduler.py Outdated Show resolved Hide resolved

dimberman force-pushed the helm-testing-framework branch from 436b391 to f91816e Compare October 21, 2020 18:27

mik-laj reviewed Oct 21, 2020

View reviewed changes

scripts/ci/libraries/_local_mounts.sh Outdated Show resolved Hide resolved

ashb reviewed Oct 21, 2020

View reviewed changes

.dockerignore Outdated Show resolved Hide resolved

ashb reviewed Oct 21, 2020

View reviewed changes

chart_tests/test_templates/git_sync_scheduler/git-sync-existing-claim.yaml Outdated Show resolved Hide resolved

dimberman force-pushed the helm-testing-framework branch from f76c0d6 to eca0f34 Compare October 21, 2020 20:47

dimberman force-pushed the helm-testing-framework branch from eca0f34 to c2960aa Compare October 22, 2020 18:13

kaxil changed the title ~~add python helm testing framework~~ Add Python Helm testing framework Oct 22, 2020

kaxil reviewed Oct 22, 2020

View reviewed changes

chart_tests/basic_helm_chart_test.py Outdated Show resolved Hide resolved

kaxil reviewed Oct 22, 2020

View reviewed changes

chart_tests/helm_template_generator.py Outdated Show resolved Hide resolved

kaxil reviewed Oct 22, 2020

View reviewed changes

chart_tests/helm_template_generator.py Outdated Show resolved Hide resolved

kaxil reviewed Oct 22, 2020

View reviewed changes

chart_tests/test_git_sync_scheduler.py Outdated Show resolved Hide resolved

kaxil reviewed Oct 22, 2020

View reviewed changes

chart_tests/helm_template_generator.py Outdated Show resolved Hide resolved

dimberman force-pushed the helm-testing-framework branch from 7ac2c24 to a4f5624 Compare October 22, 2020 21:33

mik-laj reviewed Oct 25, 2020

View reviewed changes

scripts/in_container/entrypoint_ci.sh Show resolved Hide resolved

mik-laj reviewed Oct 25, 2020

View reviewed changes

mik-laj reviewed Oct 26, 2020

View reviewed changes

TESTING.rst Show resolved Hide resolved

mik-laj approved these changes Oct 27, 2020

View reviewed changes

dimberman force-pushed the helm-testing-framework branch 2 times, most recently from 0babdba to c5e36d2 Compare October 27, 2020 23:04

dimberman added 2 commits October 27, 2020 16:04

Helm Python Testing

318264c

helm change

106af04

dimberman force-pushed the helm-testing-framework branch from c5e36d2 to 106af04 Compare October 27, 2020 23:08

add back args

698a995

dimberman merged commit 0d1ad66 into apache:master Oct 28, 2020

dimberman deleted the helm-testing-framework branch October 28, 2020 01:29

mik-laj mentioned this pull request Oct 28, 2020

Migration to Python/Go unittest helm-unittest/helm-unittest#110

Closed

michalmisiewicz pushed a commit to michalmisiewicz/airflow that referenced this pull request Oct 30, 2020

Add Python Helm testing framework (apache#11693)

879337c

* Helm Python Testing * helm change * add back args

szn pushed a commit to szn/airflow that referenced this pull request Nov 1, 2020

Add Python Helm testing framework (apache#11693)

e408606

* Helm Python Testing * helm change * add back args

potiuk pushed a commit that referenced this pull request Nov 14, 2020

Add Python Helm testing framework (#11693)

ecb3acd

* Helm Python Testing * helm change * add back args (cherry picked from commit 0d1ad66)

potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020

potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020

potiuk pushed a commit that referenced this pull request Nov 16, 2020

Add Python Helm testing framework (#11693)

633c6bd

* Helm Python Testing * helm change * add back args (cherry picked from commit 0d1ad66)

potiuk pushed a commit that referenced this pull request Nov 16, 2020

Add Python Helm testing framework (#11693)

d153de4

* Helm Python Testing * helm change * add back args (cherry picked from commit 0d1ad66)

kaxil pushed a commit that referenced this pull request Nov 18, 2020

Add Python Helm testing framework (#11693)

643998d

* Helm Python Testing * helm change * add back args (cherry picked from commit 0d1ad66)

cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021

Add Python Helm testing framework (apache#11693)

cdb5abf

* Helm Python Testing * helm change * add back args (cherry picked from commit 0d1ad66)

cognifloyd pushed a commit to cognifloyd/stackstorm-k8s that referenced this pull request Feb 16, 2022

Add Python Helm testing framework (apache/airflow#11693)

8033d91

* Helm Python Testing * helm change * add back args Partial Commit Extracted From: https://github.com/apache/airflow

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Python Helm testing framework #11693

Add Python Helm testing framework #11693

dimberman commented Oct 20, 2020

github-actions bot commented Oct 20, 2020

github-actions bot commented Oct 21, 2020

github-actions bot commented Oct 21, 2020

kaxil Oct 22, 2020

github-actions bot commented Oct 22, 2020

mik-laj Oct 25, 2020 •

edited

Loading

dimberman Oct 26, 2020

mik-laj Oct 26, 2020

dimberman Oct 26, 2020

mik-laj Oct 26, 2020

mik-laj Oct 26, 2020

github-actions bot commented Oct 26, 2020

github-actions bot commented Oct 26, 2020

mik-laj left a comment

mik-laj commented Oct 28, 2020

Add Python Helm testing framework #11693

Add Python Helm testing framework #11693

Conversation

dimberman commented Oct 20, 2020

github-actions bot commented Oct 20, 2020

github-actions bot commented Oct 21, 2020

github-actions bot commented Oct 21, 2020

kaxil Oct 22, 2020

Choose a reason for hiding this comment

github-actions bot commented Oct 22, 2020

mik-laj Oct 25, 2020 • edited Loading

Choose a reason for hiding this comment

dimberman Oct 26, 2020

Choose a reason for hiding this comment

mik-laj Oct 26, 2020

Choose a reason for hiding this comment

dimberman Oct 26, 2020

Choose a reason for hiding this comment

mik-laj Oct 26, 2020

Choose a reason for hiding this comment

mik-laj Oct 26, 2020

Choose a reason for hiding this comment

github-actions bot commented Oct 26, 2020

github-actions bot commented Oct 26, 2020

mik-laj left a comment

Choose a reason for hiding this comment

mik-laj commented Oct 28, 2020

mik-laj Oct 25, 2020 •

edited

Loading