Cleaned airflow chart values & values.schema.json #11990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correct type for multiNamespaceMode chart value * Updated values.schema.json to reflect the latest change and to be stricter * Fixed current test * Added a test to validate the values file against the schema
mik-laj
approved these changes
Oct 31, 2020
|
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed! |
github-actions
bot
added
the
okay to merge
mik-laj
approved these changes
Oct 31, 2020
|
Thanks for the quick merge ! |
szn
pushed a commit
to szn/airflow
that referenced
this pull request
Nov 1, 2020
* Correct type for multiNamespaceMode chart value * Updated values.schema.json to reflect the latest change and to be stricter * Fixed current test * Added a test to validate the values file against the schema
potiuk
pushed a commit
that referenced
this pull request
Nov 15, 2020
* Correct type for multiNamespaceMode chart value * Updated values.schema.json to reflect the latest change and to be stricter * Fixed current test * Added a test to validate the values file against the schema (cherry picked from commit e238b88)
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
* Correct type for multiNamespaceMode chart value * Updated values.schema.json to reflect the latest change and to be stricter * Fixed current test * Added a test to validate the values file against the schema (cherry picked from commit e238b88)
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
* Correct type for multiNamespaceMode chart value * Updated values.schema.json to reflect the latest change and to be stricter * Fixed current test * Added a test to validate the values file against the schema (cherry picked from commit e238b88)
kaxil
pushed a commit
that referenced
this pull request
Nov 18, 2020
* Correct type for multiNamespaceMode chart value * Updated values.schema.json to reflect the latest change and to be stricter * Fixed current test * Added a test to validate the values file against the schema (cherry picked from commit e238b88)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Correct type for multiNamespaceMode chart value * Updated values.schema.json to reflect the latest change and to be stricter * Fixed current test * Added a test to validate the values file against the schema (cherry picked from commit e238b88)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I wanted to follow up on #11675 (comment) .
Allong the way, I did:
There are still some todos for items I didn't find a description for.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.