Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Gantt View #12419

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix issues with Gantt View #12419

merged 1 commit into from
Nov 17, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 17, 2020

closes #9813
closes #9633

and does some cleanup


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

closes apache#9813
closes apache#9633

and does some cleanup
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Nov 17, 2020
Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally—appears to resolve both of the issues mentioned.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 17, 2020
@github-actions
Copy link

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!

@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 17, 2020
@potiuk
Copy link
Member

potiuk commented Nov 17, 2020

Looks like a cherry-pick candidate for 1.10.13 :)

@kaxil kaxil merged commit 506ee1f into apache:master Nov 17, 2020
@kaxil kaxil deleted the gantt-view-fx branch November 17, 2020 21:50
kaxil added a commit that referenced this pull request Nov 18, 2020
closes #9813
closes #9633

and does some cleanup
kaxil added a commit that referenced this pull request Nov 18, 2020
closes #9813
closes #9633

and does some cleanup
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gantt chart for running dag doesn't show up in Airflow 1.10.11 "Try Number" is off by 1 in the Gantt view
3 participants