Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retryer to SFTP hook connection #13065

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

TobKed
Copy link
Contributor

@TobKed TobKed commented Dec 14, 2020


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@TobKed
Copy link
Contributor Author

TobKed commented Dec 14, 2020

WDYT @mik-laj ? It is good approach to avoid connection timeouts which occurs during testing #11284 ?

@mik-laj
Copy link
Member

mik-laj commented Dec 14, 2020

@TobKed LGTM. Is it ready for rmerge?

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 14, 2020
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@TobKed TobKed marked this pull request as ready for review December 15, 2020 09:10
@TobKed
Copy link
Contributor Author

TobKed commented Dec 15, 2020

@mik-laj rebased on the latest master, ready to merge

@TobKed
Copy link
Contributor Author

TobKed commented Feb 3, 2021

@mik-laj what do you think about merging it?

@mik-laj mik-laj merged commit 9af452a into apache:master Feb 3, 2021
@mik-laj mik-laj deleted the add-timeout-to-sftp-hook branch February 3, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants