Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ui bugs in tree view #14566

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Mar 2, 2021


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

- add duration to the dagrun tooltip if it doesn't exist
- better calculate white space to put between the tree diagram and task instance list
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 2, 2021
@bbovenzi
Copy link
Contributor Author

bbovenzi commented Mar 3, 2021

Before:
Screen Shot 2021-03-03 at 11 52 37 AM

After:
Screen Shot 2021-03-03 at 11 51 57 AM

Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @bbovenzi!

🐦🐦🪨

@github-actions
Copy link

github-actions bot commented Mar 3, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 3, 2021
@ryanahamilton ryanahamilton merged commit 3f7ebfd into apache:master Mar 4, 2021
@ryanahamilton ryanahamilton deleted the tree-ui-fixes branch March 4, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
2 participants