Fix running child tasks in a subdag after clearing a successful subdag #14776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
ashb,
kaxil,
turbaszek and
XD-DENG
as code owners
ephraimbuddy
force-pushed
the
fix-child-task-not-run-in-clear-subdag
branch
from
83d1b8d
to
cd21515
Compare
kaxil
reviewed
Mar 15, 2021
ephraimbuddy
force-pushed
the
fix-child-task-not-run-in-clear-subdag
branch
from
cd21515
to
a6eac67
Compare
ashb
reviewed
Mar 16, 2021
ashb
reviewed
Mar 16, 2021
ashb
reviewed
Mar 16, 2021
ephraimbuddy
force-pushed
the
fix-child-task-not-run-in-clear-subdag
branch
from
a6eac67
to
1bb5e65
Compare
Resolved. Thanks for info on testing!!! |
kaxil
approved these changes
Mar 17, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
After successfully running a SUBDAG, clearing it (including downstream+recursive) doesn't trigger the inner tasks. Instead, the subdag is marked successful and the inner tasks all stay cleared and aren't re-run. The above problem is because the DagRun state of the subdags are not updated after clearing. This PR solves it by updating the DagRun state of all DAGs including subdags when include_subdags is True
ephraimbuddy
force-pushed
the
fix-child-task-not-run-in-clear-subdag
branch
from
1bb5e65
to
cec7ef2
Compare
ashb
approved these changes
Mar 18, 2021
ashb
pushed a commit
that referenced
this pull request
Mar 19, 2021
#14776) After successfully running a SUBDAG, clearing it (including downstream+recursive) doesn't trigger the inner tasks. Instead, the subdag is marked successful and the inner tasks all stay cleared and aren't re-run. The above problem is because the DagRun state of the subdags are not updated after clearing. This PR solves it by updating the DagRun state of all DAGs including subdags when include_subdags is True (cherry picked from commit 0521635)
kaxil
pushed a commit
that referenced
this pull request
Apr 30, 2021
potiuk
pushed a commit
that referenced
this pull request
May 9, 2021
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2021
Closes: apache/airflow#15374 This pull request follows apache/airflow#14776. Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute. GitOrigin-RevId: a4211e276fce6521f0423fe94b01241a9c43a22c
2 tasks
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2021
Closes: apache/airflow#15374 This pull request follows apache/airflow#14776. Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute. GitOrigin-RevId: a4211e276fce6521f0423fe94b01241a9c43a22c
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 27, 2021
Closes: apache/airflow#15374 This pull request follows apache/airflow#14776. Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute. GitOrigin-RevId: a4211e276fce6521f0423fe94b01241a9c43a22c
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 10, 2022
Closes: apache/airflow#15374 This pull request follows apache/airflow#14776. Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute. GitOrigin-RevId: a4211e276fce6521f0423fe94b01241a9c43a22c
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
Closes: apache/airflow#15374 This pull request follows apache/airflow#14776. Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute. GitOrigin-RevId: a4211e276fce6521f0423fe94b01241a9c43a22c
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 9, 2022
Closes: apache/airflow#15374 This pull request follows apache/airflow#14776. Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute. GitOrigin-RevId: a4211e276fce6521f0423fe94b01241a9c43a22c
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
Closes: apache/airflow#15374 This pull request follows apache/airflow#14776. Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute. GitOrigin-RevId: a4211e276fce6521f0423fe94b01241a9c43a22c
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
Closes: apache/airflow#15374 This pull request follows apache/airflow#14776. Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute. GitOrigin-RevId: a4211e276fce6521f0423fe94b01241a9c43a22c
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
Closes: apache/airflow#15374 This pull request follows apache/airflow#14776. Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute. GitOrigin-RevId: a4211e276fce6521f0423fe94b01241a9c43a22c
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
Closes: apache/airflow#15374 This pull request follows apache/airflow#14776. Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute. GitOrigin-RevId: a4211e276fce6521f0423fe94b01241a9c43a22c
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
Closes: apache/airflow#15374 This pull request follows apache/airflow#14776. Clearing a subdag with Downstream+Recursive does not automatically set the state of the parent dag so that the downstream parent tasks can execute. GitOrigin-RevId: a4211e276fce6521f0423fe94b01241a9c43a22c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13295
After successfully running a SUBDAG, clearing it
(including downstream+recursive) doesn't trigger the inner tasks.
Instead, the subdag is marked successful and the inner tasks all
stay cleared and aren't re-run.
The above problem is because the DagRun state of the subdags are not updated
after clearing. This PR solves it by updating the DagRun state of all DAGs
including subdags when include_subdags is True
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.