Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running child tasks in a subdag after clearing a successful subdag #14776

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Fix running child tasks in a subdag after clearing a successful subdag #14776

merged 4 commits into from
Mar 18, 2021

Commits on Mar 17, 2021

  1. Fix running child tasks in a subdag after clearing a successful subdag 

    After successfully running a SUBDAG, clearing it
(including downstream+recursive) doesn't trigger the inner tasks.
Instead, the subdag is marked successful and the inner tasks all
stay cleared and aren't re-run.

The above problem is because the DagRun state of the subdags are not updated
after clearing. This PR solves it by updating the DagRun state of all DAGs
including subdags when include_subdags is True
    @ephraimbuddy
    ephraimbuddy committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    703e652 View commit details
    Browse the repository at this point in the history

  2. fixup! Fix running child tasks in a subdag after clearing a successfu… 

    …l subdag
    @ephraimbuddy
    ephraimbuddy committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    4e953a1 View commit details
    Browse the repository at this point in the history

  3. fixup! fixup! Fix running child tasks in a subdag after clearing a su… 

    …ccessful subdag
    @ephraimbuddy
    ephraimbuddy committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    741fa56 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review and fix test

    @ephraimbuddy
    ephraimbuddy committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    cec7ef2 View commit details
    Browse the repository at this point in the history