Fixing ParamValidationError when executing load_file in Glue hooks/operators

[rahulraina7]

Use of s3Hook load_file is wrong and leads to an error

botocore.exceptions.ParamValidationError: Parameter validation failed:
Invalid bucket name "artifacts/glue-scripts/myscript.py": Bucket name must match the regex "^[a-zA-Z0-9.\-_]{1,255}$" or be an ARN matching the regex "^arn:(aws).*:(s3|s3-object-lambda):[a-z\-0-9]+:[0-9]{12}:accesspoint[/:][a-zA-Z0-9\-]{1,63}$|^arn:(aws).*:s3-outposts:[a-z\-0-9]+:[0-9]{12}:outpost[/:][a-zA-Z0-9\-]{1,63}[/:]accesspoint[/:][a-zA-Z0-9\-]{1,63}$"

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[rahulraina7]

I have also updated the glue hook to use IAM arn for its execution role.
As there can be a path associated with a role name, This won't work if there is an actual path present.

Example:

{'Role': {'Path': '/dataplatform/glue/', 'RoleName': 'glue-role', 'RoleId': 'AROAU2X5YFLK4EU5OCRWW', 'Arn': 'arn:aws:iam::****:role/dataplatform/glue/glue-role', 'CreateDate': datetime.datetime(2021, 5, 23, 14, 50, 3, tzinfo=tzutc()), 'AssumeRolePolicyDocument': {'Version': '2012-10-17', 'Statement': [{'Sid': '', 'Effect': 'Allow', 'Principal': {'Service': 'glue.amazonaws.com'}, 'Action': 'sts:AssumeRole'}]}, 'MaxSessionDuration': 3600, 'RoleLastUsed': {'LastUsedDate': datetime.datetime(2021, 5, 24, 6, 1, 50, tzinfo=tzutc()), 'Region': 'ap-southeast-1'}}, 'ResponseMetadata': {'RequestId': '25bffed5-ef5d-41eb-8959-16e75961d896', 'HTTPStatusCode': 200, 'HTTPHeaders': {'x-amzn-requestid': '25bffed5-ef5d-41eb-8959-16e75961d896', 'content-type': 'text/xml', 'content-length': '1005', 'date': 'Mon, 24 May 2021 11:14:04 GMT'}, 'RetryAttempts': 0}}

Its better to use Arn since the underlying API in boto3 supports that

[potiuk]

Is it possible to add some unit tests with mocking for that ?

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

[rahulraina7]

Updated tests. Please review @uranusjr , @o-nikolas

[eladkal]

@rahulraina7 the glue tests are failing

[rahulraina7]

@rahulraina7 the glue tests are failing

Fixed with the latest commit.

[github-actions]

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!