Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill the "job_id" field for airflow task run command. #16108

Merged
merged 1 commit into from May 27, 2021

Conversation

@sighingnow
Copy link
Contributor

@sighingnow sighingnow commented May 27, 2021

I have encounter the same exception backtrace when running dag with Kubernetes executor in #13805, with airflow 2.0.2. This one-line change does fix the problem.

Fixes #13805, see also comment #13805 (comment).

Fixes apache#13805, see comment apache#13805 (comment).


Signed-off-by: Tao He <sighingnow@gmail.com>
@sighingnow
Copy link
Contributor Author

@sighingnow sighingnow commented May 27, 2021

Replace #16043.

ashb
ashb approved these changes May 27, 2021
@github-actions
Copy link

@github-actions github-actions bot commented May 27, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@sighingnow
Copy link
Contributor Author

@sighingnow sighingnow commented May 27, 2021

Hi @ashb, could we get this one landed? The failure is not caused by this PR and happends on master as well.

@ashb ashb added this to the Airflow 2.1.1 milestone May 27, 2021
@ashb ashb merged commit cdc9f1a into apache:master May 27, 2021
57 of 59 checks passed
@boring-cyborg
Copy link

@boring-cyborg boring-cyborg bot commented May 27, 2021

Awesome work, congrats on your first merged pull request!

kaxil added a commit to astronomer/airflow that referenced this issue Jun 2, 2021
kaxil added a commit to astronomer/airflow that referenced this issue Jun 2, 2021
…aw` for KubeExecutor (apache#16108)

(cherry picked from commit cdc9f1a)
(cherry picked from commit 55fc6f6)
kaxil added a commit to astronomer/airflow that referenced this issue Jun 2, 2021
…aw` for KubeExecutor (apache#16108)

(cherry picked from commit cdc9f1a)
(cherry picked from commit 55fc6f6)
(cherry picked from commit 7a6492e)
jhtimmins added a commit to astronomer/airflow that referenced this issue Jun 3, 2021
andormarkus pushed a commit to andormarkus/airflow that referenced this issue Jun 5, 2021
ashb added a commit that referenced this issue Jun 22, 2021
…aw` for KubeExecutor (#16108)

(cherry picked from commit cdc9f1a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants