Update chain() and cross_downstream() to support XComArgs #16732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for `XComArgs` in `chain()` helper function - Updated type annotations for `XComArg` in `cross_downstream()` helper function
josh-fell
requested review from
ashb,
kaxil,
turbaszek and
XD-DENG
as code owners
ashb
requested changes
Jul 1, 2021
|
Should an examples be added to the documentation/docstring as well? |
Great idea. I'll expand the examples in the docstrings for |
uranusjr
reviewed
Jul 4, 2021
uranusjr
approved these changes
Jul 6, 2021
ashb
reviewed
Jul 6, 2021
ashb
reviewed
Jul 8, 2021
ashb
reviewed
Jul 8, 2021
ashb
approved these changes
Jul 8, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
ashb
removed
the
full tests needed
uranusjr
changed the title
chain() and cross_downstream() to support XComArgs
josh-fell
added a commit
to josh-fell/airflow
that referenced
this pull request
Jul 19, 2021
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XComArgsinchain()helper functionXComArgincross_downstream()helper functiontest_baseoperator.pyCloses: #16635
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.