-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TaskGroup support in chain() #17456
Conversation
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
bc08076
to
23d320b
Compare
Those two ( |
However any help to make them non-flaky is definitely most welcome :) |
Happy to take a look and help any way I can. Perhaps a silly question but is this test always failing for the same exception? If not, is there a set of logs I can look through to see any failure trends? > assert success_callback_called.value == 1
E assert 0 == 1
E + where 0 = <Synchronized wrapper for c_int(0)>.value |
Only by looking at individual failed actions. I used to have a "quarantine" summary of tasks, but it has proven to be really a pain to maintain. But that actually be a good idea, to keep such status of all failed tests somewhere. Maybe you could do that :). I used to keep quarantined tests status in GitHub Issue (as strange as it might seem) but that was a bit "clunky". Maybe we could keep it somewhere else. Google Spreadsheet might be a possibility for one. We could push status of failed tests for every 'master' merge push. to make it more "robust" and only include stuff that should "work". |
23d320b
to
e39b3af
Compare
Related to: #17083, #16635
This PR ensures that
TaskGroups
can be used to set dependencies while calling thechain()
method. Support forXComArgs
andEdgeModifiers
has been implemented in previous PRs: #16732, #17099^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.