Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EdgeModifier support for chain() #17099

Merged
merged 6 commits into from
Jul 25, 2021

Conversation

josh-fell
Copy link
Contributor

Closes: #17083

  • Added support for EdgeModifier in chain() helper function
  • Added additional tests in test_baseoperator.py

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jul 20, 2021
@kaxil kaxil closed this Jul 20, 2021
@kaxil kaxil removed the full tests needed We need to run full set of tests for this PR to merge label Jul 20, 2021
@kaxil kaxil reopened this Jul 20, 2021
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jul 20, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil
Copy link
Member

kaxil commented Jul 22, 2021

Tests are failing @josh-fell

@josh-fell
Copy link
Contributor Author

Tests are failing @josh-fell

Some of these failures look to be resource-related. Rebasing and let's see how the new test runs turn out.

@josh-fell
Copy link
Contributor Author

@kaxil Not as many failures after the rebase.

The 4 failing MSSQL tests are failing for the same reason in this issue comment.

The failing Postgres and MySQL jobs pass locally for the offending test "test_scheduler_job.py":
./breeze --python 3.9 --backend postgres --postgres-version 13 tests tests/jobs/test_scheduler_job.py
image

./breeze --python 3.6 --backend mysql --mysql-version 5.7 tests tests/jobs/test_scheduler_job.py
image

How should I proceed?

@potiuk
Copy link
Member

potiuk commented Jul 25, 2021

Looks like transient errors only. Merging

@potiuk potiuk merged commit 29d8e7f into apache:main Jul 25, 2021
@josh-fell josh-fell deleted the chain-with-edgemodifier branch July 26, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update chain() to support Labels
4 participants