Fixes #16972 - Slugify role session name in AWS base hook

[mcreenan]

closes: #16972

This change ensures the role session name only contains valid characters according to the pattern defined by the RoleSessionName parameter in STS AssumeRole (https://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRole.html).

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[potiuk]

Nice!

[github-actions]

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

[potiuk]

Rebuilding

[potiuk]

Can you please rebase to latest main @mcreenan - I think I fixed all the "red-build" stability issues that plagued us in the last week

[mcreenan]

Can you please rebase to latest main @mcreenan - I think I fixed all the "red-build" stability issues that plagued us in the last week

Done... I think. I'm new to this style of workflow.

[potiuk]

Yeah. Airflow is a beast and keeping it tamed is a special kinda skill. Sometimes it shows it's humours :)

[potiuk]

Now - we are back to "real" issues - static checks are failing - there are some CHANGELOG,rst entries wrong (single instead of double backticks)

[potiuk]

And some unit tests

[mcreenan]

Now - we are back to "real" issues - static checks are failing - there are some CHANGELOG,rst entries wrong (single instead of double backticks)

Can you help me understand what's going on here? I didn't change CHANGELOG.rst.

And some unit tests

I'll look at those.

[mcreenan]

There's something strange going on. The tests that are failing aren't at all related to what I changed (especially the google ones). When I run the aws providers tests locally, I get 2 other unrelated errors.

[potiuk]

Please rebase to latest main - we had some problems with main broken. Those problem should be fixed now.

[mcreenan]

Please rebase to latest main - we had some problems with main broken. Those problem should be fixed now.

Done.

[mcreenan]

Is there anything else I need to do with this PR? It looks like the latest run of tests still had some failures unrelated to this change.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!