-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding JWT, IP filtering, and direct session login support for SalesforceHook #17399
Conversation
Co-authored-by: kurtqq <47721902+kurtqq@users.noreply.github.com>
@eladkal FYI if you'd like to review. |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Closes: #17192
Adding login and authentication support when using the
SalesforceHook
:New fields were also added to the connection form for the "Salesforce" type:
Connection documentation has also been updated to describe each connection field and what type of login/authentication is related.
Refactored unit tests to include mock implementations of the 4 supported auth/login types.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.