Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JWT, IP filtering, and direct session login support for SalesforceHook #17399

Merged
merged 9 commits into from
Aug 6, 2021

Conversation

josh-fell
Copy link
Contributor

@josh-fell josh-fell commented Aug 3, 2021

Closes: #17192

  • Adding login and authentication support when using the SalesforceHook:

    • JWT bearer authentication
    • IP filtering (allow-listing)
    • Direct session/instance access
  • New fields were also added to the connection form for the "Salesforce" type:
    image

  • Connection documentation has also been updated to describe each connection field and what type of login/authentication is related.

  • Refactored unit tests to include mock implementations of the 4 supported auth/login types.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@josh-fell
Copy link
Contributor Author

@eladkal FYI if you'd like to review.

@eladkal eladkal self-requested a review August 4, 2021 04:14
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@eladkal eladkal merged commit 5c0e98c into apache:main Aug 6, 2021
@josh-fell josh-fell deleted the salesforcehook-add-auth-types branch August 6, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding additional login support for SalesforceHook
3 participants