Use dag_maker fixture in models/test_taskinstance.py
#17425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
Aug 5, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
ephraimbuddy
force-pushed
the
use-dag_maker-fixture-on-taskinstance
branch
from
1b99c4f
to
da6de91
Compare
ephraimbuddy
commented
Aug 5, 2021
ephraimbuddy
force-pushed
the
use-dag_maker-fixture-on-taskinstance
branch
from
b83588f
to
ad5d257
Compare
ephraimbuddy
commented
Aug 5, 2021
ashb
approved these changes
Aug 5, 2021
ephraimbuddy
force-pushed
the
use-dag_maker-fixture-on-taskinstance
branch
2 times, most recently
from
63f7055
to
4594b5d
Compare
ashb
reviewed
Aug 6, 2021
| @@ -480,6 +480,7 @@ def __call__(self, dag_id='test_dag', session=None, **kwargs): | |||
| self.start_date = DEFAULT_DATE | |||
| self.kwargs['start_date'] = self.start_date | |||
| self.dag = DAG(dag_id, **self.kwargs) | |||
| self.dag.fileloc = request.module.__file__ | |||
There was a problem hiding this comment.
Thanks for the idea!
ashb
approved these changes
Aug 6, 2021
ephraimbuddy
force-pushed
the
use-dag_maker-fixture-on-taskinstance
branch
4 times, most recently
from
579032e
to
bc5a3c8
Compare
The change applies dag_maker fixture in test_taskinstance.py fixup! Use `dag_maker` fixture in models/test_taskinstance.py Update tests/models/test_taskinstance.py Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> fixup! Update tests/models/test_taskinstance.py fixup! fixup! Update tests/models/test_taskinstance.py fixup! Use `dag_maker` fixture in models/test_taskinstance.py Use dag_maker on test_render_k8s_pod_yaml use inspect to get dag_maker module Set dag_maker file location to caller Fix pre-commit
ephraimbuddy
force-pushed
the
use-dag_maker-fixture-on-taskinstance
branch
from
bc5a3c8
to
b396c68
Compare
potiuk
approved these changes
Aug 8, 2021
|
This test is flaky in the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change applies dag_maker fixture in test_taskinstance.py
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.