Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Invalid log order in ElasticsearchTaskHandler #17551

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

suhanovv
Copy link
Contributor

Fixes for 17512

The previous implementation assumed a one-time definition of the offset when creating an instance of the class, which led to the appearance of the same offset in the logs, while the documentation says about uniqueness values.

Log messages with specific log_id are sorted based on `offset`,
    which is a unique integer indicates log message's order.

My implementation adds generation of an offset when creating a log message

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 11, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Aug 11, 2021
@potiuk potiuk merged commit 944dc32 into apache:main Aug 11, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 11, 2021

Awesome work, congrats on your first merged pull request!

@suhanovv suhanovv deleted the fix-elk-log-order branch August 12, 2021 07:48
@suhanovv suhanovv restored the fix-elk-log-order branch August 12, 2021 07:48
@suhanovv suhanovv deleted the fix-elk-log-order branch August 12, 2021 07:54
@whitleykeith
Copy link

When will this fix be available? The provider hasn't been updated with these changes yet

@potiuk
Copy link
Member

potiuk commented Aug 24, 2021

~ week or so. We are following about monthly cadence of releasing providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logging area:providers okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants