-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check docker-compose version in breeze #18536
Conversation
8b78b8e
to
9e59a08
Compare
BTW. Can someone check if it works on Mac as well? Especialy with latest docker compose which is built-in in docker in latest Docker Desktop |
We already have one version check for Docker compose. Can we update it? Lines 595 to 609 in ab7acfd
|
Yeah. I totally forgot about it :). The message from Felix this morning reminde me about it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this on MacOS with latest Docker Desktop for Mac 4.0.1
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
We started to use some newer features in docker-compose of breeze. They are new enough (May 2020) that older versions of docker-compose do not work with them. This PR checks if the docker-compose is >= 1.29
9e59a08
to
4eb8e09
Compare
New version with removed check for v2 (As it seems docker-archive/compose-cli#1917 is alredy fixed in latest two release candidates). It would be awesome @feluelle @mik-laj if you could check it with both "disable-v2" and "enable-v2" |
We started to use some newer features in docker-compose of breeze.
They are new enough (May 2020) that older versions of
docker-compose do not work with them.
This PR checks if the docker-compose is >= 1.29
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.