-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IntegrityError in DagFileProcessor.manage_slas
#19553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
including HA (high availability) scheduler
label
Nov 12, 2021
uranusjr
requested changes
Nov 12, 2021
uranusjr
approved these changes
Nov 12, 2021
github-actions
bot
added
the
full tests needed
We need to run full set of tests for this PR to merge
label
Nov 12, 2021
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
ephraimbuddy
force-pushed
the
fix-integrity-error-sla
branch
from
November 12, 2021 13:43
a924320
to
c33b41d
Compare
The DagFileProcessor.manage_slas does not consider if an SlaMiss already exists in DB while inserting slas. If an SLA for a task is missed and recorded, on checking SLA again, this task comes up again if there's no recent run of the task and we try to insert the record into the SlaMiss table again, this results in Integrity error. This PR fixes that by avoiding insert if the record already exists Co-Authored-By: Tzu-ping Chung <uranusjr@gmail.com>
kaxil
force-pushed
the
fix-integrity-error-sla
branch
from
November 12, 2021 23:45
c33b41d
to
3456251
Compare
kaxil
approved these changes
Nov 12, 2021
jedcunningham
pushed a commit
that referenced
this pull request
Dec 7, 2021
The DagFileProcessor.manage_slas does not consider if an SlaMiss already exists in DB while inserting slas. If an SLA for a task is missed and recorded, on checking SLA again, this task comes up again if there's no recent run of the task and we try to insert the record into the SlaMiss table again, this results in Integrity error. This PR fixes that by avoiding insert if the record already exists Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> Co-authored-by: Kaxil Naik <kaxilnaik@apache.org> (cherry picked from commit 9519bf6)
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:Scheduler
including HA (high availability) scheduler
full tests needed
We need to run full set of tests for this PR to merge
type:bug-fix
Changelog: Bug Fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DagFileProcessor.manage_slas does not consider if an SlaMiss already exists in
DB while inserting slas.
If an SLA for a task is missed and recorded, on checking SLA again, this task
comes up again if there's no recent run of the task and we try to insert
the record into the SlaMiss table again, this results in Integrity error.
This PR fixes that by avoiding insert if the record already exists
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.