Declare data interval fields as serializable #19616
Conversation
So they are available in PythonVirtualenvOperator. Also added a few more keys that are trivially serializable but was missing previously. A test is added to make sure we declare all keys so this does not happen again in the future.
boring-cyborg
bot
added
the
area:core-operators
There was a problem hiding this comment.
Thank you @uranusjr !
LGTM
I’m not really sure why exactly
tiandtask_instanceare not being serialised. Those exist back when #9394 was implemented so they seem to be omitted intentionally? But I didn’t see any discussion on the decision.
@feluelle maybe you can provide some insight on this as the author of #9394
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
|
#12985 is another issue related to the |
|
Isn't that the same case here: #19618 |
Doesn't look like - as execution_date was alredy there ? |
|
Yeah that one is a different issue, probably due to we changing the variable to a lazy proxy. |
(cherry picked from commit 264cb09)
So they are available in PythonVirtualenvOperator. Also added a few more keys that are trivially serializable but was missing previously.
A test is added to make sure we declare all keys so this does not happen again in the future.
See #9394
I’m not really sure why exactly
tiandtask_instanceare not being serialised. Those exist back when #9394 was implemented so they seem to be omitted intentionally? But I didn’t see any discussion on the decision.dswas also omitted for some reason, but it’s just a string so I just added it.cc @eladkal