-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix argument error in AzureContainerInstancesOperator #19668
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Thanks for catching this! Can you also add a test to make sure |
Happy to add some unit tests. |
Actually I considered a bit and didn’t have a very good idea how to test this. Maybe someone can suggest a way, but if not, I think it’s OK to merge this as-is. |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Awesome work, congrats on your first merged pull request! |
@potiuk do you know when this can be released? |
We release providers ~end of month so soon |
Closes #18074
The code was producing the error
TypeError: __init__() got multiple values for argument 'sdk_client'
.I created this small test to understand the problem.
When the keyword is missing from
AzureContainerInstanceHook
the first positional argument is assumed to besdk_client
.When you change the code to
AzureContainerInstanceHook(conn_id="abc")
, this issue is fixed.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.