Fix argument error in AzureContainerInstancesOperator

[chinwobble]

Closes #18074

The code was producing the error TypeError: __init__() got multiple values for argument 'sdk_client'.

I created this small test to understand the problem.

from typing import Any, Dict, List, Optional, Sequence, Union

class BaseHook:
    pass


class AzureBaseHook(BaseHook):
    def __init__(self, sdk_client: Any, conn_id: str = 'azure_default'):
        print(sdk_client)
        self.sdk_client = sdk_client
        self.conn_id = conn_id
        super().__init__()

class AzureContainerInstanceHook(AzureBaseHook):
    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs, sdk_client="Container Instances")
        # self.connection = self.get_conn()


myhook = AzureContainerInstanceHook("abc")

When the keyword is missing from AzureContainerInstanceHook the first positional argument is assumed to be sdk_client.
When you change the code to AzureContainerInstanceHook(conn_id="abc"), this issue is fixed.

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[uranusjr]

Thanks for catching this! Can you also add a test to make sure AzureContainerInstancesOperator will not break again if someone adds a new hook argument?

[chinwobble]

Thanks for catching this! Can you also add a test to make sure AzureContainerInstancesOperator will not break again if someone adds a new hook argument?

Happy to add some unit tests.
I'm not very familiar with python unit testing. Could you show me how to do that?

[uranusjr]

Actually I considered a bit and didn’t have a very good idea how to test this. Maybe someone can suggest a way, but if not, I think it’s OK to merge this as-is.

[github-actions]

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[chinwobble]

@potiuk do you know when this can be released?

[potiuk]

We release providers ~end of month so soon