Coalesce extra params to None in KubernetesHook
#19694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using UI form widgets FAB provides a empty string by default for every param. This turns out to make a difference sometimes. E.g. in this hook, we decide what to do depending on whether the param `is not None` -- and if you've created the connection in the UI, even though you didn't supply a value for this param, it will be `not None` In this case, I do not think this is a breaking change because e.g. if `kubeconfig_path` is empty string then loading it should fail. This should just allow better functioning of the hook.
boring-cyborg
bot
added
provider:cncf-kubernetes
reasonable |
jedcunningham
approved these changes
Nov 19, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using UI form widgets FAB provides a empty string by default for every param. This turns out to make a difference sometimes. E.g. in this hook, we decide what to do depending on whether the param
is not None-- and if you've created the connection in the UI, even though you didn't supply a value for this param, it will benot NoneIn this case, I do not think this is a breaking change because e.g. if
kubeconfig_pathis empty string then loading it should fail. This should just allow better functioning of the hook.