Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SNS example DAG and rst #21475

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Conversation

ferruzzi
Copy link
Contributor

@ferruzzi ferruzzi commented Feb 9, 2022

Does what it says on the tin. This is the first step in a larger project to complete and standardize the sample dags and documentation inside the Amazon provider package.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@ferruzzi
Copy link
Contributor Author

ferruzzi commented Feb 9, 2022

Missed adding the reference to the new docs in the provider.yaml file. Not sure how I missed that, update incoming.

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a small comment in the doc.

ferruzzi and others added 2 commits February 9, 2022 13:06
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 10, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants