Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECS sample DAG and Docs to new standards #21828

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

ferruzzi
Copy link
Contributor

Part of a project to simplify and standardize AWS sample dags and docs in preparation for adding System Testing.

Related: #21523
Related: #21475


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Comment on lines -18 to -23
"""
This is an example dag for EcsOperator.

The task "hello_world" runs `hello-world` task in `c` cluster.
It overrides the command in the `hello-world-container` container.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to remove it?
Since we have dag.doc_md = __doc__ this explanatory block will appear in the UI

Copy link
Contributor Author

@ferruzzi ferruzzi Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the only sample DAG in the AWS provider package that had it, and I didn't see any added value in this instance.

Discussed it a little on Slack here: https://apache-airflow.slack.com/archives/CJ1LVREHX/p1644527546510599****

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 28, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants