-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix annotations not getting added to cleanup pods #21484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonstacks, overall looks good. Can you instead add test coverage in these 2 places:
airflow/chart/tests/test_annotations.py
Line 284 in 5dc6338
class TestPerComponentPodAnnotations: |
def test_annotations(self): |
Sorry, yes, it is a little messy - feel free to open a follow up PR doing some cleanup if you want.
@jedcunningham, thanks for the review and feedback. Can you tell me if this is more in line with what you are thinking? |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Thanks @jonstacks 🎉 |
closes: #21469
This PR propagates the
airflowPodAnnotations
that the documentation says is applied to all airflow pods to the pods launched by thecleanup
cronojob. It also allows for settingpodAnnotations
specifically for the cleanup pods.