Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotations not getting added to cleanup pods #21484

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Fix annotations not getting added to cleanup pods #21484

merged 2 commits into from
Feb 11, 2022

Conversation

jonstacks
Copy link
Contributor

closes: #21469

This PR propagates the airflowPodAnnotations that the documentation says is applied to all airflow pods to the pods launched by the cleanup cronojob. It also allows for setting podAnnotations specifically for the cleanup pods.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Feb 10, 2022
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonstacks, overall looks good. Can you instead add test coverage in these 2 places:

class TestPerComponentPodAnnotations:

def test_annotations(self):

Sorry, yes, it is a little messy - feel free to open a follow up PR doing some cleanup if you want.

@jonstacks
Copy link
Contributor Author

@jedcunningham, thanks for the review and feedback. Can you tell me if this is more in line with what you are thinking?

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 11, 2022
@jedcunningham jedcunningham merged commit 8c1512b into apache:main Feb 11, 2022
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Feb 11, 2022
@jedcunningham
Copy link
Member

Thanks @jonstacks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to supply custom annotations for cleanup cron job pods
4 participants