Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide for DataprocInstantiateInlineWorkflowTemplateOperator #22062

Merged
merged 6 commits into from
Mar 8, 2022

Conversation

NiloFreitas
Copy link
Contributor

Added the example of DataprocInstantiateInlineWorkflowTemplateOperator in the documentation and example DAG

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 7, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Mar 7, 2022

Failing tests and static checks :(

@mik-laj
Copy link
Member

mik-laj commented Mar 8, 2022

Can you add a reference to this section in Python API reference docs?

.. seealso::
For more information on how to use this operator, take a look at the guide:
:ref:`howto/operator:BigQueryCheckOperator`

@NiloFreitas
Copy link
Contributor Author

The Python API reference docs for the DataprocInstantiateInlineWorkflowTemplateOperator already has a reference (which is broken):

.. seealso::
Please refer to:
https://cloud.google.com/dataproc/docs/reference/rest/v1beta2/projects.regions.workflowTemplates/instantiateInline

So you want me to replace it with this

.. seealso::
For more information on how to use this operator, take a look at the guide:
:ref:howto/operator:DataprocInstantiateInlineWorkflowTemplateOperator

Or fix the link with this reference?

.. seealso::
Please refer to:
https://cloud.google.com/dataproc/docs/reference/rest/v1/projects.regions.workflowTemplates/instantiateInline

@mik-laj
Copy link
Member

mik-laj commented Mar 8, 2022

What do you think about fixing a link AND adding a new reference to our guide?

@potiuk
Copy link
Member

potiuk commented Mar 8, 2022

It needs some fixes in the list of documentation left.

@mik-laj mik-laj changed the title Patch Dataproc documentation Add guide for DataprocInstantiateInlineWorkflowTemplateOperator Mar 8, 2022
@mik-laj mik-laj merged commit dd0724f into apache:main Mar 8, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 8, 2022

Awesome work, congrats on your first merged pull request!

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 8, 2022
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers full tests needed We need to run full set of tests for this PR to merge kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants