-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide for DataprocInstantiateInlineWorkflowTemplateOperator #22062
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Failing tests and static checks :( |
Can you add a reference to this section in Python API reference docs? airflow/airflow/providers/google/cloud/operators/bigquery.py Lines 126 to 128 in fb6b2d1
|
The Python API reference docs for the DataprocInstantiateInlineWorkflowTemplateOperator already has a reference (which is broken):
So you want me to replace it with this
Or fix the link with this reference?
|
What do you think about fixing a link AND adding a new reference to our guide? |
It needs some fixes in the list of documentation left. |
Awesome work, congrats on your first merged pull request! |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Added the example of DataprocInstantiateInlineWorkflowTemplateOperator in the documentation and example DAG