Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable scheme for webserver probes #22815

Merged
merged 6 commits into from
Jul 4, 2022

Conversation

dan-vaughan
Copy link
Contributor

We want to be able to terminate TLS at the webserver pod, which requires configuring the liveness and readiness probes to use https.

  • Add configurable scheme to webserver probes
  • Update values schema
  • Add unittest

- add scheme to webserver probes
- update values schema
- add unittest
@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Apr 7, 2022
@potiuk
Copy link
Member

potiuk commented Apr 25, 2022

It's not the best idea to use TLS termination in the webserver. Usually in K8S this should happen in the ingress and very rarely (if at all) you use TLS termination in application.

Why would you want to do this?

@dan-vaughan
Copy link
Contributor Author

The k8s security standards for the company I work for require us to terminate TLS at the pod to prevent unencrypted ingress -> pod communication

@potiuk
Copy link
Member

potiuk commented May 17, 2022

Interesting. I guess I will leave it to @jedcunningham and @ephraimbuddy to decide if they want to merge it, I see that might be useful for such level of a bit "paranoid" security.

Can you please fix the static checks and tests however @dan-vaughan

flipstone42 and others added 2 commits May 31, 2022 17:43
- Fix casing issues with scheme
- Fix formatting issues with unit-tests
@potiuk
Copy link
Member

potiuk commented Jun 4, 2022

Static checks are still failing. I suggest to rebase and install/run pre-commit before that.

@dan-vaughan
Copy link
Contributor Author

Hey @potiuk, I've fixed the failing static checks, please let me know if there's anything else you need from me

@potiuk potiuk merged commit 34b2ed4 into apache:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants