-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable scheme for webserver probes #22815
Conversation
- add scheme to webserver probes - update values schema - add unittest
It's not the best idea to use TLS termination in the webserver. Usually in K8S this should happen in the ingress and very rarely (if at all) you use TLS termination in application. Why would you want to do this? |
The k8s security standards for the company I work for require us to terminate TLS at the pod to prevent unencrypted ingress -> pod communication |
Interesting. I guess I will leave it to @jedcunningham and @ephraimbuddy to decide if they want to merge it, I see that might be useful for such level of a bit "paranoid" security. Can you please fix the static checks and tests however @dan-vaughan |
- Fix casing issues with scheme - Fix formatting issues with unit-tests
Static checks are still failing. I suggest to rebase and install/run pre-commit before that. |
Hey @potiuk, I've fixed the failing static checks, please let me know if there's anything else you need from me |
We want to be able to terminate TLS at the webserver pod, which requires configuring the liveness and readiness probes to use https.