-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new MyPy errors in main #22884
Fix new MyPy errors in main #22884
Conversation
BTW. A number of those errors (except the big google Retry) are because |
Those MyPe errors are side effect of some new dependencies.
6e627e8
to
81c31c9
Compare
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Why are If someone wants a deterministic order, then can use a list or tuple as the value. |
I just fixed consistency. I think there is no particular reason. I do not think it matters as long as it consistent. You can make a PR to change it ti Iterable -but it has to be consistent in all providers and code. |
It also could be that somewhere in the code len() is used and that would make it not good candidate for Iterable. |
@potiuk from the description of those attributes, I don't see why any code would do |
Yeah. Could be :) . I do not see any problem with changing it to Iterable if it passes all the tests. I |
Those MyPe errors are side effect of some new dependencies.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.