Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PythonVirtualenvOperator templated_fields #23559

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented May 7, 2022

The PythonVirtualenvOperator templated_fields override PythonOperator templated_fields which caused functionality not to work as expected.
fixes: #23557


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

The `PythonVirtualenvOperator` templated_fields override `PythonOperator` templated_fields which caused functionality not to work as expected.
fixes: apache#23557
@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label May 7, 2022
@eladkal eladkal added this to the Airflow 2.3.1 milestone May 7, 2022
airflow/operators/python.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label May 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

1 similar comment
@github-actions
Copy link

github-actions bot commented May 9, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@eladkal eladkal merged commit 1657bd2 into apache:main May 9, 2022
@eladkal eladkal deleted the python branch May 9, 2022 15:18
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label May 17, 2022
ephraimbuddy pushed a commit that referenced this pull request May 17, 2022
* Fix `PythonVirtualenvOperator` templated_fields
The `PythonVirtualenvOperator` templated_fields override `PythonOperator` templated_fields which caused functionality not to work as expected.
fixes: #23557

(cherry picked from commit 1657bd2)
ephraimbuddy pushed a commit that referenced this pull request May 21, 2022
* Fix `PythonVirtualenvOperator` templated_fields
The `PythonVirtualenvOperator` templated_fields override `PythonOperator` templated_fields which caused functionality not to work as expected.
fixes: #23557

(cherry picked from commit 1657bd2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

templates_dict, op_args, op_kwargs no longer rendered in PythonVirtualenvOperator
3 participants