-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debounce status highlighting in Grid view #24710
Conversation
CC: @pierrejeambrun |
How does it feel with a delay of 400ms? Did they number come from anywhere particular? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine - only question is if 400ms is too big or too small
It's the same delay we already have for Tooltips. Maybe we should make that a single variable across the app? |
Nice improvement 👍 |
Actually, looks like we weren't consistent with our tooltip delays. I made a |
* Add delay / debounce to not always highlight tasks * fix linting * single delay variable at 200ms (cherry picked from commit c7feb31)
Right now, any amount of hovering over a status in grid view will trigger highlighting. Instead, we should make sure the action is intentional by including a debounce with a 200ms delay.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst
, in newsfragments.