Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply flake8-logging-format changes to tests #24931

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

josh-fell
Copy link
Contributor

Related: #23597 #24910

This is some pre-work for hopefully including the flake8-logging-format extension in CI. There are roughly 88 file changes so splitting these up into smaller chunks.

After the initial sweeps are completed we can do a final pass when formally implementing the extension in CI.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:Apache provider:google Google (including GCP) related issues labels Jul 8, 2022
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment - we should get rid of the try/except/log here and replace them with fixture. The best code is no code :)

@josh-fell josh-fell marked this pull request as draft July 20, 2022 13:49
@josh-fell josh-fell force-pushed the flake8-logging-format-tests branch from f6fdb9e to 2de4b89 Compare July 29, 2022 20:47
@josh-fell josh-fell marked this pull request as ready for review July 29, 2022 20:52
@josh-fell josh-fell force-pushed the flake8-logging-format-tests branch from 2de4b89 to d7c1cf5 Compare July 30, 2022 17:04
@potiuk potiuk merged commit dd06797 into apache:main Aug 4, 2022
@josh-fell josh-fell deleted the flake8-logging-format-tests branch August 4, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants