Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added labels to airflow specific pods #25031

Merged

Conversation

rishkarajgi
Copy link
Contributor

@rishkarajgi rishkarajgi commented Jul 13, 2022


Adds the ability to inject additional labels to specific components. This currently supports addition to scheduler, webserver, worker, pod template, triggerer, flower, cleanup and create user job.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jul 13, 2022
@rishkarajgi rishkarajgi marked this pull request as ready for review July 13, 2022 19:27
@pgvishnuram
Copy link
Contributor

@jedcunningham - pls see if this can be merged

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component specific labels should go on all objects, not just pods, like the global labels do. Also there are merge conflicts currently.

@rishkarajgi rishkarajgi marked this pull request as draft August 22, 2022 19:56
@rishkarajgi rishkarajgi marked this pull request as ready for review August 22, 2022 20:32
@rishkarajgi rishkarajgi requested review from jedcunningham and removed request for dstandish August 22, 2022 20:48
@rishkarajgi
Copy link
Contributor Author

Component specific labels should go on all objects, not just pods, like the global labels do. Also there are merge conflicts currently.

@jedcunningham Have addressed the above. Please take a look

tests/charts/test_flower.py Show resolved Hide resolved
chart/values.yaml Outdated Show resolved Hide resolved
tests/charts/test_webserver.py Outdated Show resolved Hide resolved
tests/charts/test_webserver.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants