-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: custom labels for extrasecrets/configmaps #25283
Chart: custom labels for extrasecrets/configmaps #25283
Conversation
c9936b1
to
cc4382d
Compare
Looks like the failing checks are not related to this PR so I won't retrigger the test runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jedcunningham please take a look, I removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a little unfortunate the conditional is tied to the description but I didn't come up with anything better yesterday when I hacked on it a bit either.
This PR allows users to specify custom labels for secrets/configmaps created with
extraSecrets
/extraConfigMaps
params^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.