Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: custom labels for extrasecrets/configmaps #25283

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

Aakcht
Copy link
Contributor

@Aakcht Aakcht commented Jul 25, 2022

This PR allows users to specify custom labels for secrets/configmaps created with extraSecrets/extraConfigMaps params


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jul 25, 2022
@Aakcht Aakcht force-pushed the extra_secrets_configmaps_labels branch from c9936b1 to cc4382d Compare July 26, 2022 03:31
@Aakcht
Copy link
Contributor Author

Aakcht commented Jul 26, 2022

Looks like the failing checks are not related to this PR so I won't retrigger the test runs.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chart/values.schema.json Outdated Show resolved Hide resolved
chart/values.schema.json Outdated Show resolved Hide resolved
@Aakcht
Copy link
Contributor Author

Aakcht commented Aug 4, 2022

@jedcunningham please take a look, I removed description and moved default up a level, though I had to make an exception for extraconfigmap/secrets in values_schema.schema.json .

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a little unfortunate the conditional is tied to the description but I didn't come up with anything better yesterday when I hacked on it a bit either.

@jedcunningham jedcunningham merged commit 58fb646 into apache:main Aug 4, 2022
@jedcunningham jedcunningham added this to the Airflow Helm Chart 1.7.0 milestone Aug 4, 2022
@Aakcht Aakcht deleted the extra_secrets_configmaps_labels branch August 5, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants