-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding podAnnotations to StatsD deployment template #25732
Adding podAnnotations to StatsD deployment template #25732
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Please, next time you are working on an issue that is assigned to someone else, please notify the issue. I do not want to sound rude, but it is simple fact that I just wasted time on this because I implemented it as well. Time that could have been spent more wisely. |
I think the problem was .... you were not assigned @sbrandtb :). It was likely an omission. When you read all the conversation it looked like you wanted to work on it , but yeah - it's our fault we have not assigned you. BTW. I think it's quite expected that there is some duplication of work. There is also a value in doing stuff (learning). Merging is not the ultimate and only value, the process of making PR. getting reviews and feedback is valuable as well. There is no sane way to make sure that there is no duplication of work, but when you realise this is not the only value, you get more acceptance of doing stuff in parallel by different people. Code is often liability and if you get others contribute the code you came with as an idea, this is actually cool opportunity to work on it together. Since this PR is already out - in the spirit of what I wrote above - I'd encourage you @sbrandtb to turn into reviewer here and make your comments and help with leading that to completion. There is even bigger value in being reviewer when such code is contributed - you learn how to communicate your review comments, you learn how to look at the change with other perspective and you will likely notice things that you wouldn't have noticed when you wrote it. And a good learning experience too. At the end "Community over code" is what matters most (this is the ASF motto). |
Ah I see you de-assigned yourself (my mistake) - so yeah, probably asking where you stand would be cool. but that does not change my proposal regardless. |
@potiuk As mentioned in the issue: No offense. And MR looks good to me, but I do not have the power to +1 |
Awesome work, congrats on your first merged pull request! |
Adding PodAnnotation to StatsD deployment template.
Closes: #25446