Find cross-group tasks in iter_mapped_dependants #25793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
aip-42-expansion-from-another-group
branch
from
b63090a
to
5f05c01
Compare
ashb
approved these changes
Aug 18, 2022
|
Is linked issue correct? It links to another PR |
|
I fixed the incorrect linked issue. Thanks for catching it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25775
As explained in the issue, this is caused by our dependant detection code not correctly look up tasks across groups. Since looking across group requires the task to know about its root group, the lookup logic has been moved from TaskMixin to AbstractOperator. We only use the logic with tasks right now, so it’s OK.