Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo secrets backend config caching #26223

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

pdebelak
Copy link
Contributor

@pdebelak pdebelak commented Sep 7, 2022

Remove secrets backend caching for configuration.

This has caused several issues and has benefits in only certain situations so it doesn't seem worth the trouble.

Resolves #26185


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Sep 7, 2022

Hey @ashb - for the 2.4.0 - the secret backend caching has turned out to be far more problematic than we thought and we decied with @pdebelak to revert it - it should get in the 2.4.0 (and possibly 2.3.5 if we decide to release it).

@potiuk potiuk added this to the Airflow 2.4.0 milestone Sep 7, 2022
@potiuk potiuk merged commit c63834c into apache:main Sep 8, 2022
@jedcunningham jedcunningham added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) type:bug-fix Changelog: Bug Fixes and removed changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) labels Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webserver fails to pull secrets from Hashicorp Vault on start up
3 participants