Cache the custom secrets backend so the same instance gets re-used #25556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#25555 This uses `functools.lru_cache` to re-use the same secrets backend instance between the `conf` global when it loads configuration from secrets and uses outside the `configuration` module like variables and connections. Previously, each fetch of a configuration value from secrets would use its own secrets backend instance.
|
you misdiagnosed the problem. see comment in #25555 . This will not solve your problem. |
2 tasks
|
OK. Let's see. You convinced me - but you have to fix tests failing (there were some) and it woudl be great to add unit test covering it showing that there is one instance after (and failing before the change). |
Also add unit test to confirm that only one secrets backend instance gets created.
potiuk
approved these changes
Aug 6, 2022
|
Nice. Thanks for being persistent! |
|
👍 I appreciate you digging into this with me. Thank you! |
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 15, 2022
…25556) * Cache the custom secrets backend so the same instance gets re-used Fixes #25555 This uses `functools.lru_cache` to re-use the same secrets backend instance between the `conf` global when it loads configuration from secrets and uses outside the `configuration` module like variables and connections. Previously, each fetch of a configuration value from secrets would use its own secrets backend instance. Also add unit test to confirm that only one secrets backend instance gets created. (cherry picked from commit 5863c42)
53 tasks
2 tasks
2 tasks
pdebelak
added a commit
to pdebelak/airflow
that referenced
this pull request
Sep 7, 2022
…-used (apache#25556)" This reverts commit 5863c42.
ephraimbuddy
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 13, 2022
…-used (apache#25556)" This reverts commit ed9bf28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #25555
This uses
functools.lru_cacheto re-use the same secrets backend instance between theconfglobal when it loads configuration from secrets and uses outside theconfigurationmodule like variables and connections. Previously, each fetch of a configuration value from secrets would use its own secrets backend instance.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.