Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert airflow/hooks to __future__.annotations #26302

Closed
wants to merge 1 commit into from

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Sep 10, 2022


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Sep 10, 2022
@potiuk potiuk requested review from ashb, uranusjr, dstandish, kaxil and josh-fell and removed request for ashb September 10, 2022 15:54
@@ -15,8 +15,10 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
# fmt: off
# fmt:, off
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a typo?

@@ -15,8 +15,10 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
# fmt: off
# fmt:, off
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# fmt:, off
# fmt: off

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Does it even do anything?)

Copy link
Member Author

@potiuk potiuk Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah They were small corrections I've fixed to make the PR's green (my initial replace screwed up and joined those with from __future__ import annotations.

Yeah. They actualy do (and I think the comma does not really matter) - they prevent Black from re-formatting those files . The problem with such long names of classes we have in the dict that (despite the max-line-length) it will make lines too long and they fail in flake. One of the very few cases where black is WRONG.

Copy link
Member Author

@potiuk potiuk Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove those comas.

@potiuk
Copy link
Member Author

potiuk commented Sep 13, 2022

Closing as this one will be merged as part of #26289 #26290. See https://lists.apache.org/thread/81fr042s5d3v17v83bpo24tnrr2pp0fp for details

@potiuk potiuk closed this Sep 13, 2022
@potiuk potiuk deleted the future_annotations_14 branch December 2, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow future-annotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants