Apply PEP-563 (Postponed Evaluation of Annotations) to non-core airflow #26289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Sep 10, 2022
potiuk
force-pushed
the
future_annotations_1
branch
from
62d21a8
to
5f3fee2
Compare
ashb
approved these changes
Sep 12, 2022
This was referenced Sep 13, 2022
potiuk
requested review from
jedcunningham,
turbaszek and
mik-laj
as code owners
potiuk
changed the title
potiuk
force-pushed
the
future_annotations_1
branch
2 times, most recently
from
135e841
to
a353cc0
Compare
This PR applies PEP-563 to all non-core airflow Python files - i.e. those that we usually do not cherry-pick to v2-* branches. There will be a follow-up to apply the "core changes" right after with the intention to be cherry-picked to v2-* branch before 2.4.0 release candidate is ready, in order to make cherry-picking easier. This PR is a result of combining some of the 47 PRs reviewed and approved separately (otherwise it would have been unreviewable) The history of those PRs can be changed in: https://github.com/apache/airflow/pulls?q=is%3Apr+label%3Afuture-annotations+is%3Aopen Relevant discussion: https://lists.apache.org/thread/81fr042s5d3v17v83bpo24tnrr2pp0fp Lazy consensus call: https://lists.apache.org/thread/l74nvjh8tgbtojllhwkcn7f8mfnlz4jq
potiuk
force-pushed
the
future_annotations_1
branch
from
a353cc0
to
4546916
Compare
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 14, 2022
This PR applies PEP-563 to all core airflow Python files - i.e. those that we want to cherry-pick to v2-* branches in order to make cherry-picking for the upcoming 2.4* releases easier. There was a separate PR (apache#26289) with non-core changes that are not going to be cherry-picked.. This PR is a result of combining some of the 47 PRs reviewed and approved separately (otherwise it would have been unreviewable) The history of those PRs can be changed in: https://github.com/apache/airflow/pulls?q=is%3Apr+label%3Afuture-annotations+is%3Aopen Relevant discussion: https://lists.apache.org/thread/81fr042s5d3v17v83bpo24tnrr2pp0fp Lazy consensus call: https://lists.apache.org/thread/l74nvjh8tgbtojllhwkcn7f8mfnlz4jq
potiuk
added a commit
that referenced
this pull request
Sep 14, 2022
…26290) This PR applies PEP-563 to all core airflow Python files - i.e. those that we want to cherry-pick to v2-* branches in order to make cherry-picking for the upcoming 2.4* releases easier. There was a separate PR (#26289) with non-core changes that are not going to be cherry-picked.. This PR is a result of combining some of the 47 PRs reviewed and approved separately (otherwise it would have been unreviewable) The history of those PRs can be changed in: https://github.com/apache/airflow/pulls?q=is%3Apr+label%3Afuture-annotations+is%3Aopen Relevant discussion: https://lists.apache.org/thread/81fr042s5d3v17v83bpo24tnrr2pp0fp Lazy consensus call: https://lists.apache.org/thread/l74nvjh8tgbtojllhwkcn7f8mfnlz4jq
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 14, 2022
This is a follow up after apache#26289 and 26290 to automatically add __future__.annotations import to all new files (except empty __init__). Also the isort configureation is moved to pyproject toml to be consistent across manual and pre-commit runs of isort
potiuk
added a commit
that referenced
this pull request
Sep 14, 2022
…26290) This PR applies PEP-563 to all core airflow Python files - i.e. those that we want to cherry-pick to v2-* branches in order to make cherry-picking for the upcoming 2.4* releases easier. There was a separate PR (#26289) with non-core changes that are not going to be cherry-picked.. This PR is a result of combining some of the 47 PRs reviewed and approved separately (otherwise it would have been unreviewable) The history of those PRs can be changed in: https://github.com/apache/airflow/pulls?q=is%3Apr+label%3Afuture-annotations+is%3Aopen Relevant discussion: https://lists.apache.org/thread/81fr042s5d3v17v83bpo24tnrr2pp0fp Lazy consensus call: https://lists.apache.org/thread/l74nvjh8tgbtojllhwkcn7f8mfnlz4jq (cherry picked from commit d67ac59)
potiuk
added a commit
that referenced
this pull request
Sep 14, 2022
This is a follow up after #26289 and 26290 to automatically add __future__.annotations import to all new files (except empty __init__). Also the isort configureation is moved to pyproject toml to be consistent across manual and pre-commit runs of isort
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 14, 2022
…26290) This PR applies PEP-563 to all core airflow Python files - i.e. those that we want to cherry-pick to v2-* branches in order to make cherry-picking for the upcoming 2.4* releases easier. There was a separate PR (#26289) with non-core changes that are not going to be cherry-picked.. This PR is a result of combining some of the 47 PRs reviewed and approved separately (otherwise it would have been unreviewable) The history of those PRs can be changed in: https://github.com/apache/airflow/pulls?q=is%3Apr+label%3Afuture-annotations+is%3Aopen Relevant discussion: https://lists.apache.org/thread/81fr042s5d3v17v83bpo24tnrr2pp0fp Lazy consensus call: https://lists.apache.org/thread/l74nvjh8tgbtojllhwkcn7f8mfnlz4jq (cherry picked from commit d67ac59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies PEP-563 to all non-core airflow Python files - i.e.
those that we usually do not cherry-pick to v2-* branches. There
will be a follow-up to apply the "core changes" right after with
the intention to be cherry-picked to v2-* branch before 2.4.0
release candidate is ready, in order to make cherry-picking
easier. The follow up PR is #26290.
This PR is a result of combining some of the 47 PRs reviewed
and approved separately (otherwise it would have been unreviewable)
The history of those PRs can be changed in:
https://github.com/apache/airflow/pulls?q=is%3Apr+label%3Afuture-annotations+is%3Aopen
Relevant discussion: https://lists.apache.org/thread/81fr042s5d3v17v83bpo24tnrr2pp0fp
Lazy consensus call: https://lists.apache.org/thread/l74nvjh8tgbtojllhwkcn7f8mfnlz4jq
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.