Add __future__.annotations automatically by isort #26383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Sep 14, 2022
ashb
reviewed
Sep 14, 2022
potiuk
force-pushed
the
add-annotation-imports-automatically
branch
from
c82644e
to
fe93565
Compare
|
Added arrays also in "skip" section and excluded .pyi from isort. |
potiuk
force-pushed
the
add-annotation-imports-automatically
branch
2 times, most recently
from
7faced2
to
0f04885
Compare
uranusjr
approved these changes
Sep 14, 2022
This is a follow up after apache#26289 and 26290 to automatically add __future__.annotations import to all new files (except empty __init__). Also the isort configureation is moved to pyproject toml to be consistent across manual and pre-commit runs of isort
potiuk
force-pushed
the
add-annotation-imports-automatically
branch
from
0f04885
to
e8dee3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up after #26289 and 26290 to automatically add future.annotations import to all new files (except empty init).
Also the isort configureation is moved to pyproject toml to be consistent across manual and pre-commit runs of isort
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.