Slightly faster downgrade tests #26939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
force-pushed
the
slightly-faster-downgrade-tests
branch
from
a7e2e9b
to
b12b9dd
Compare
|
Locally this saved about 15s for me -- not huge, but it's not a very complex change either so I think worth it |
ashb
force-pushed
the
slightly-faster-downgrade-tests
branch
from
b12b9dd
to
fe7f2bf
Compare
There are two changes here: 1. Don't reserialize the dags. It's not part of the test so just adds extra time 2. Use `cached_app` in the migrations, rather than creating three copies of the app. To _ensure_ this has no side-effect outside of migrations we also purge the cached app at the end of running migrations, but only if it was already imported.
ashb
force-pushed
the
slightly-faster-downgrade-tests
branch
from
fe7f2bf
to
dbca09f
Compare
jedcunningham
approved these changes
Oct 13, 2022
jedcunningham
approved these changes
Oct 13, 2022
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
There are two changes here: 1. Don't reserialize the dags. It's not part of the test so just adds extra time 2. Use `cached_app` in the migrations, rather than creating three copies of the app. To _ensure_ this has no side-effect outside of migrations we also purge the cached app at the end of running migrations, but only if it was already imported. (cherry picked from commit 1449ebb)
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
There are two changes here: 1. Don't reserialize the dags. It's not part of the test so just adds extra time 2. Use `cached_app` in the migrations, rather than creating three copies of the app. To _ensure_ this has no side-effect outside of migrations we also purge the cached app at the end of running migrations, but only if it was already imported. (cherry picked from commit 1449ebb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes here:
Don't reserialize the dags. It's not part of the test so just adds extra time
Use
cached_appin the migrations, rather than creating three copies of the app.To ensure this has no side-effect outside of migrations we also purge the cached app at the end of running migrations, but only if it was already imported.
ll conflict)