-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
27010 : Add new files to parsing queue on every loop of dag processsing #27060
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need tests to prove that this works. Also, benchmarking may be required.
cc: @ashb
I saw quite a few users complaining recently about similar behaviour, so it would be great to review and merge it before 2.4.3. Deque should be fine when it comes to performance (at least all the comparision and micro-benchmarking I saw confirm that). But I think we should review this one carefully also taking into account the processing order the user can choose. |
conflicts need resolving and some benchmarks would be coo. Also cc: @ashb for comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but it needs another committer as this is very core change.
I'll look at the code in a moment, but how is this different from setting the existing dag dir refresh interval config to 0? |
Existing implementation adds new file to parsing queue only if parsing queue is empty. This change to make sure if file_path is refreshed on list_interval config, new files are added to parsing queue without waiting for existing file parsing. |
Got it thanks! (I was on my phone and it was difficult to read the code fully there) Feature LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too. Nice and simple solution.
The apache#27060 was built before normalisation was applied and merging it caused static-check failure
closes: #27010
Once file paths are refreshed on dag_dir_list interval. If there are any new files added, add them to parsing queue at start so those can be parsed immediately instead of waiting of existing parsing queue to finish
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.