Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples and howtos about sensors #27333

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Oct 27, 2022

The examples and docs were missing for a number of built-in sensors. This documentation and examples do not add much but at least give the user information that there are such sensors available when they look at our documentation.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk requested a review from kaxil as a code owner October 27, 2022 20:22
@boring-cyborg boring-cyborg bot added area:core-operators Operators, Sensors and hooks within Core Airflow kind:documentation labels Oct 27, 2022
@potiuk
Copy link
Member Author

potiuk commented Oct 27, 2022

Small but I think nice :)

Copy link
Member

@XD-DENG XD-DENG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems two wrong titles. Plus two minor points.

airflow/sensors/time_delta.py Show resolved Hide resolved
docs/apache-airflow/howto/operator/time.rst Outdated Show resolved Hide resolved
docs/apache-airflow/howto/operator/time.rst Outdated Show resolved Hide resolved
docs/apache-airflow/howto/operator/time.rst Outdated Show resolved Hide resolved
The examples and docs were missing for a number of built-in
sensors. This documentation and examples do not add much but at least
give the user information that there are such sensors available when
they look at our documentation.
@potiuk
Copy link
Member Author

potiuk commented Oct 28, 2022

All addressed @XD-DENG

@potiuk potiuk merged commit 280a0e7 into apache:main Oct 28, 2022
@potiuk potiuk deleted the add-docs-about-examples branch October 28, 2022 15:21
@ephraimbuddy ephraimbuddy added type:doc-only Changelog: Doc Only type:improvement Changelog: Improvements and removed type:doc-only Changelog: Doc Only labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow kind:documentation type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants