Add max_wait for exponential_backoff in BaseSensor #27597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tial_backoff is on
boring-cyborg
bot
added
the
area:core-operators
eladkal
reviewed
Nov 10, 2022
dstandish
reviewed
Nov 10, 2022
dstandish
reviewed
Nov 10, 2022
Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
dstandish
reviewed
Nov 10, 2022
dstandish
changed the title
dstandish
reviewed
Nov 10, 2022
dstandish
approved these changes
Nov 10, 2022
dstandish
reviewed
Nov 10, 2022
o-nikolas
approved these changes
Nov 11, 2022
jedcunningham
approved these changes
Nov 11, 2022
|
Awesome work, congrats on your first merged pull request! |
|
Thanks @hussein-awala! Congrats on your first commit 🎉 |
Adityamalik123
pushed a commit
to Adityamalik123/airflow
that referenced
this pull request
Nov 12, 2022
Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make use of
exponential_backoffto increase wait times between pokes, but we need to control the maximum wait time as we do with tasks retries when we activateretry_exponential_backoff,where we can setmax_retry_delayto use a fixed delay after a certain number of retries.