Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue on exception when retrieving metadata #27665

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Nov 14, 2022

There are cases where just retrieval of package metadata during entrypoint discovery will cause an error (example
#27596).

In this case we should skip the package and continue discovery, while logging a warning rather than crash.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

There are cases where just retrieval of package metadata during
entrypoint discovery will cause an error (example
apache#27596).

In this case we should skip the package and continue discovery,
while logging a warning rather than crash.
@potiuk potiuk requested review from uranusjr and ashb November 14, 2022 16:10
@potiuk potiuk added this to the Airflow 2.4.4 milestone Nov 14, 2022
@potiuk potiuk merged commit 48c2108 into apache:main Nov 14, 2022
@potiuk potiuk deleted the add-protection-when-retrieving-package-metadata branch November 14, 2022 19:33
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Nov 15, 2022
@ephraimbuddy ephraimbuddy modified the milestones: Airflow 2.4.4, Airflow 2.5.0 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants