Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm chart NOTES.txt to show correct URL #28264

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix helm chart NOTES.txt to show correct URL #28264

merged 1 commit into from
Jan 18, 2023

Conversation

okue
Copy link
Contributor

@okue okue commented Dec 9, 2022

What happened

Airflow Webserver URL is incorrect shown by helm install/upgrade.

https://helm.sh/docs/chart_template_guide/notes_files/

How to reproduce

values.yaml:

ingress:
  web:
    enabled: true
    annotations: {}
    path: "/path"
    pathType: "ImplementationSpecific"
    hosts:
     - name: "localhost"
       tls:
         enabled: false
         secretName: ""

breeze k8s deploy-airflow --upgrade results is
image

What you think should happen instead

Airflow Webserver:
      http:////

should be

Airflow Webserver:
      http://localhost/path/

Modifications in this PR

  • Fix NOTES.txt

Result

image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Dec 9, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 9, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@okue
Copy link
Contributor Author

okue commented Dec 13, 2022

@dstandish @jedcunningham could you please review? 🙇

@eladkal eladkal added this to the Airflow Helm Chart 1.8.0 milestone Dec 20, 2022
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@potiuk potiuk merged commit 9d891fa into apache:main Jan 18, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 18, 2023

Awesome work, congrats on your first merged pull request!

@okue okue deleted the minorfix-helm-notes.txt branch January 25, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants