Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit dnspython to < 2.3.0 until eventlet incompatibitliy is solved #28962

Merged
merged 1 commit into from Jan 15, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 15, 2023

The dnspython has been released 2 hours ago and apparently eventlet that cassandra-driver uses is not compatible with the new version.

Until the problem is fixed, we should limit dnspython to <2.3.0.

Related: eventlet/eventlet#781


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Jan 15, 2023

@ephraimbuddy @pierrejeambrun -> in case you will be pushing a new version of v2_5_test, likely that one should be cherry-picked. It is only relevant for the reason of constraints - because it turns out that new dnspython is not compatible with the way how cassandra driver + eventlet patch the dnspython during import (and fail) so it would be good when next constraints are regenerated for 2.5, the dnspython is not upgraded to 2.3.0.

The dnspython has been released 2 hours ago and apparently eventlet
that cassandra-driver uses is not compatible with the new version.

Until the problem is fixed, we should limit dnspython to <2.3.0.

Related: eventlet/eventlet#781
@potiuk
Copy link
Member Author

potiuk commented Jan 15, 2023

Looks like I also had to do the same with "async" extra of Airlow @pierrejeambrun to keep PROD images being built.

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the dnspython being added to async packages extra group though?

@potiuk
Copy link
Member Author

potiuk commented Jan 15, 2023

Not sure about the dnspython being added to async packages extra group though?

I think, it is the easiest way to handle the problem. The problem is that whenever eventlet is installed and imported, it attempts to patch dnspython if it finds it during import (!) (and fails when dnspython 2.3.0 is installed).

So basically when we install eventlet we should never, ever (until it is fixed) allow dnspython >=2.3.0 to be installed, because importing eventlet will fail 🤷

The only way to do it is to add dnspython in all extras that also install eventlet (we have no other way to limit dnspython but adding it to extra's requires).

@potiuk
Copy link
Member Author

potiuk commented Jan 15, 2023

BTW. Kudos to @mik-laj for adding the PROD image unit tests - because those tests (running imports of a number of extras we have there) detected that we also need to fix the async extra.

@potiuk
Copy link
Member Author

potiuk commented Jan 15, 2023

All looks good. Merging.

@potiuk potiuk merged commit d169df7 into apache:main Jan 15, 2023
@potiuk potiuk deleted the limit-dnspython branch January 15, 2023 22:39
@potiuk potiuk added this to the Airflow 2.5.1 milestone Jan 17, 2023
@pierrejeambrun pierrejeambrun added the type:misc/internal Changelog: Misc changes that should appear in change log label Jan 17, 2023
pierrejeambrun pushed a commit that referenced this pull request Jan 17, 2023
…28962)

The dnspython has been released 2 hours ago and apparently eventlet
that cassandra-driver uses is not compatible with the new version.

Until the problem is fixed, we should limit dnspython to <2.3.0.

Related: eventlet/eventlet#781
(cherry picked from commit d169df7)
ephraimbuddy pushed a commit that referenced this pull request Jan 18, 2023
@ephraimbuddy ephraimbuddy removed the type:misc/internal Changelog: Misc changes that should appear in change log label Jan 18, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 18, 2023
ephraimbuddy pushed a commit that referenced this pull request Jan 18, 2023
@ephraimbuddy ephraimbuddy added type:misc/internal Changelog: Misc changes that should appear in change log and removed changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants