Sync v2-5-stable with v2-5-test to release 2.5.1 #28997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c568874)
pierrejeambrun
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
|
I think you might also want to add #28962 |
…28962) The dnspython has been released 2 hours ago and apparently eventlet that cassandra-driver uses is not compatible with the new version. Until the problem is fixed, we should limit dnspython to <2.3.0. Related: eventlet/eventlet#781 (cherry picked from commit d169df7)
pierrejeambrun
added
the
type:misc/internal
|
Right, I forgot about that, thank you. I just added it :). |
pierrejeambrun
removed
the
type:misc/internal
ephraimbuddy
force-pushed
the
v2-5-test
branch
from
9d6c5ad
to
b7347ce
Compare
The eventlet/eventlet#782 fixed error that caused the need to limit dnspython and eventlet 0.33.3 has been released. We can now remove the limit for dnspython as long as we also limit eventlet to >=0.33.3. (cherry picked from commit eaf5675)
ephraimbuddy
force-pushed
the
v2-5-test
branch
from
b7347ce
to
fe397d2
Compare
|
The failing "check that image builds quickly" is fine and we can ignore it. The image will not build quickly now until we update constraints because the eventlet>=0.33.3 will conflict with the current constraints. This should fix itself after constraints will get updated (and it should succeed when we re-run it after this build gets merged and constraints will be pushed). |
|
Ah I see that it even works now :) |
ephraimbuddy
force-pushed
the
v2-5-test
branch
from
fe397d2
to
49867b6
Compare
ephraimbuddy
approved these changes
Jan 18, 2023
potiuk
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fix for #28988.
To prepare
2.5.1rc2